Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log exceptions for thumbnail generation as warnings #13737

Conversation

samtfm
Copy link
Contributor

@samtfm samtfm commented Mar 22, 2021

SUMMARY

Log these exceptions as warnings since thumbnail generation is very error prone on selenium

TEST PLAN

ADDITIONAL INFORMATION

https://sentry.io/organizations/preset-inc/issues/2073254864/?project=1827134

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@samtfm samtfm changed the title log exceptions for thumbnail generation as warnings fix: log exceptions for thumbnail generation as warnings Mar 22, 2021
@samtfm samtfm marked this pull request as ready for review March 30, 2021 16:04
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #13737 (e4a60eb) into master (3e64679) will decrease coverage by 1.34%.
The diff coverage is 53.53%.

❗ Current head e4a60eb differs from pull request most recent head 50c48f0. Consider uploading reports for the commit 50c48f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13737      +/-   ##
==========================================
- Coverage   77.43%   76.08%   -1.35%     
==========================================
  Files         933      945      +12     
  Lines       47093    48461    +1368     
  Branches     5818     6242     +424     
==========================================
+ Hits        36465    36872     +407     
- Misses      10485    11438     +953     
- Partials      143      151       +8     
Flag Coverage Δ
cypress 56.02% <28.39%> (-0.48%) ⬇️
hive ?
mysql 80.60% <88.57%> (+0.04%) ⬆️
postgres 80.63% <88.57%> (+0.04%) ⬆️
presto 80.29% <88.57%> (+0.04%) ⬆️
python 80.87% <88.57%> (-0.23%) ⬇️
sqlite 80.19% <88.57%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/SqlLab/components/QueryTable.jsx 66.66% <ø> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 56.01% <ø> (ø)
superset-frontend/src/chart/chartReducer.ts 48.59% <ø> (-15.79%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...frontend/src/components/Checkbox/CheckboxIcons.tsx 83.33% <ø> (ø)
...frontend/src/components/DatabaseSelector/index.tsx 55.05% <ø> (ø)
...perset-frontend/src/components/FormLabel/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Loading/index.tsx 100.00% <ø> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 16.66% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx 85.29% <ø> (+0.37%) ⬆️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e64679...50c48f0. Read the comment docs.

@willbarrett willbarrett merged commit 31b14dc into apache:master Apr 5, 2021
@willbarrett willbarrett deleted the samtfm/quieter-thumbnail-generation-errors branch April 5, 2021 18:43
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* log errors for thumbnail generation as warnings

* fix: ex_info -> exc_info
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants