Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log exceptions for thumbnail generation as warnings #13737

Merged
merged 2 commits into from
Apr 5, 2021
Merged

fix: log exceptions for thumbnail generation as warnings #13737

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7e7443
log errors for thumbnail generation as warnings
samtfm Mar 22, 2021
50c48f0
fix: ex_info -> exc_info
samtfm Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset/utils/screenshots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,13 @@ def compute_and_cache( # pylint: disable=too-many-arguments
try:
payload = self.get_screenshot(user=user, window_size=window_size)
except Exception as ex: # pylint: disable=broad-except
logger.error("Failed at generating thumbnail %s", ex)
logger.warning("Failed at generating thumbnail %s", ex, ex_info=True)

if payload and window_size != thumb_size:
try:
payload = self.resize_image(payload, thumb_size=thumb_size)
except Exception as ex: # pylint: disable=broad-except
logger.error("Failed at resizing thumbnail %s", ex)
logger.warning("Failed at resizing thumbnail %s", ex, ex_info=True)
samtfm marked this conversation as resolved.
Show resolved Hide resolved
payload = None

if payload:
Expand Down