Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FE: Import for Queries #14054

Closed

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

Addeed an import button for saved queries in the subMenu.

  • Imported object is matched against existing objects based on uuid
  • If there are conflicts in the file being imported, user is informed and can choose to overwrite or cancel the import
  • Any other underlying sources that don’t yet exist should be created.
  • User should be prompted for db credentials if needed
  • Any underlying sources that exist and conflict shouldn’t be overwritten
  • User sees a confirmation toast

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

import-before

AFTER:

import-after

TEST PLAN

Testing has been implemented to ensure the existence of the new import button and modal.

ADDITIONAL INFORMATION

  • Has associated issue: https://app.clubhouse.io/preset/story/214/fe-import-query
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams
Copy link
Member Author

Continued at #14091

@lyndsiWilliams lyndsiWilliams deleted the lyndsi/import-saved-queries branch October 15, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant