feat: FE: Import for Queries II #14091
Conversation
…si/import-saved-queries-fe
| @@ -218,6 +219,16 @@ export function handleBulkDashboardExport(dashboardsToExport: Dashboard[]) { | |||
| ); | |||
| } | |||
|
|
|||
| export function handleBulkSavedQueryExport( | |||
There was a problem hiding this comment.
This and some of the changes above have already been merged, no?
There was a problem hiding this comment.
Yes, I just pulled the changed and there was a small merge conflict but I just fixed it and have everything merged and up to date. So far so good!
|
Looks great, @lyndsiWilliams! Did you test the feature by importing an exported saved query, and if so can you update the test plan to include that? Thanks! |
…si/import-saved-queries-fe
I've updated the test plan with gifs and more details. |
Codecov Report
@@ Coverage Diff @@
## master #14091 +/- ##
==========================================
- Coverage 79.71% 79.54% -0.17%
==========================================
Files 942 942
Lines 47709 47729 +20
Branches 6009 6016 +7
==========================================
- Hits 38029 37968 -61
- Misses 9559 9640 +81
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@hughhhh Ephemeral environment spinning up at http://35.162.128.11:8080. Credentials are |
|
/testenv up FEATURE_VERSIONED_EXPORT=true |
|
@hughhhh Ephemeral environment spinning up at http://34.218.229.50:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
* Copied changes over * Tests passing * Import testing complete
mistercrunch
added
🏷️ bot
SUMMARY
Added an import button for saved queries in the subMenu.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TEST PLAN
Testing has been implemented to ensure the existence and functionality of the new import button and modal.
The following gifs demonstrate exporting a saved query then directly importing that same saved query:
Part 1: Export saved query, view file name to verify that we import the same file, open import model, click "Choose File"
Part 2: Select saved query to import (note same file name), type "overwrite" to confirm
Part 3: Click "Overwrite" then observe confirmation toast, overwritten saved query, and updated "Modified" timestamp
ADDITIONAL INFORMATION