fix(dashboard): cross filter chart highlight when filters badge icon clicked #16233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16233 +/- ##
==========================================
+ Coverage 76.71% 76.74% +0.02%
==========================================
Files 996 996
Lines 53080 53158 +78
Branches 6739 6763 +24
==========================================
+ Hits 40721 40796 +75
- Misses 12130 12132 +2
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
|
@junlincc Ephemeral environment spinning up at http://54.201.91.128:8080. Credentials are |
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
|
@kgabryje Ephemeral environment spinning up at http://18.237.98.47:8080. Credentials are |
villebro
approved these changes
Aug 13, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 13, 2021
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)
|
🏷 2021.31 |
amitmiran137
pushed a commit
that referenced
this pull request
Aug 16, 2021
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 9f07295)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes highlighting the chart emitting a cross filter when magnifier icon in filter's badge is clicked. Before, nothing happened when icon was clicked. Now it highlights and scrolls the chart to view and changes tab if needed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see #16220
After:
Screen.Recording.2021-08-12.at.16.43.52.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @junlincc @jinghua-qa