fix: Remove Advanced Analytics tag for 2 charts #16240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16240 +/- ##
==========================================
+ Coverage 76.65% 76.69% +0.03%
==========================================
Files 996 996
Lines 53149 53266 +117
Branches 6770 6824 +54
==========================================
+ Hits 40743 40852 +109
- Misses 12176 12183 +7
- Partials 230 231 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
changed the title
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://52.26.147.33:8080. Credentials are |
michael-s-molina
approved these changes
Aug 12, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷 2021.31 |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 13, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin (cherry picked from commit cdcc161)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin (cherry picked from commit cdcc161)
amitmiran137
pushed a commit
that referenced
this pull request
Aug 16, 2021
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin (cherry picked from commit cdcc161)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin (cherry picked from commit cdcc161)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* removing AA tag from TimeTableChartPlugin * package bump for echarts (removes AA tag there) * package-lock bump for new echarts plugin (cherry picked from commit 569053b)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Two charts (Timeseries Table and Mixed Timeseries (via ECharts)) do not currently have Advanced Analytics, but were tagged as though they do. This PR removes the tag for Timeseries Table in two spots - in the repo (why is this even here?) and in the superset-ui plugin (why is this not the one we're using?). It also removes it from the relevant part of the ECharts plugin.
Brings in the 0.17.83 release for this change.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to the viz gallery, select the Advanced analytics tag, and make sure these two don't show up.
ADDITIONAL INFORMATION