feat: add force option to report screenshots #17853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
ch24621b
branch
from
94392a1 to
a1ef4fd
Compare
betodealmeida
force-pushed
the
ch24621b
branch
from
ad52455 to
ec2c200
Compare
betodealmeida
commented
Dec 22, 2021
| @@ -512,6 +513,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({ | |||
| const data: any = { | |||
| ...currentAlert, | |||
| type: isReport ? 'Report' : 'Alert', | |||
| force_screenshot: contentType === 'chart' && !isReport ? 'true' : 'false', | |||
There was a problem hiding this comment.
This is made configurable for reports in #17855
betodealmeida
commented
Dec 22, 2021
| @@ -181,7 +175,7 @@ def _get_url( | |||
| user_friendly=user_friendly, | |||
| dashboard_id_or_slug=self._report_schedule.dashboard_id, | |||
| standalone=DashboardStandaloneMode.REPORT.value, | |||
| force=force, | |||
| # force=force, TODO (betodealmeida) implement this | |||
There was a problem hiding this comment.
This is currently not supported by the dashboard API (only the chart API), so I thought it would be better to leave it out for now.
lyndsiWilliams
approved these changes
Dec 22, 2021
eschutho
reviewed
Jan 5, 2022
|
|
||
| id = sa.Column(sa.Integer, primary_key=True) | ||
| type = sa.Column(sa.String(50), nullable=False) | ||
| force_screenshot = sa.Column(sa.Boolean, default=False) |
There was a problem hiding this comment.
does this need a chart_id property?
9 tasks
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* Update existing tests * Add backend test * feat: add force option to report screenshots * Add tests * Rebase fixes * Do not force screenshot on dashboard alerts
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* Update existing tests * Add backend test * feat: add force option to report screenshots * Add tests * Rebase fixes * Do not force screenshot on dashboard alerts
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a new column
force_screenshotto the reports/alerts model. For alerts with charts this is always set to true. For reports and alerts with dashboards this is currently set to false, and is made configurable for reports in #17855.When the flag is true, when generating a screenshot for the alert/report the cache will be bypassed.
Depends on #17695.
MIGRATION
DB migration adds a new column
force_screenshot, set to true for existing alerts with charts, false otherwise.Results:
Current: 0.34 s
10+: 0.35 s
100+: 0.39 s
1000+: 0.74 s
10000+: 3.58 s
100000+: 32.59 s
1000000+: 453.84 s
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
SELECT force_screenshot FROM report_schedule, check that it's true for the alert and false for the report.ADDITIONAL INFORMATION