feat: configure force_screenshot #17855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
betodealmeida
force-pushed
the
ch24621b
branch
from
ad52455 to
ec2c200
Compare
|
❗ Please consider rebasing your branch to avoid db migration conflicts. |
betodealmeida
force-pushed
the
ch24621c
branch
3 times, most recently
from
5272bd9 to
3c81d2e
Compare
betodealmeida
force-pushed
the
ch24621c
branch
from
3c81d2e to
61e0148
Compare
lyndsiWilliams
approved these changes
Dec 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #17855 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 1609 1609
Lines 64887 64887
Branches 6863 6863
=======================================
Hits 43419 43419
Misses 19603 19603
Partials 1865 1865
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
❗ Please consider rebasing your branch to avoid db migration conflicts. |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* Update existing tests * Add backend test * feat: add force option to report screenshots * Add tests * Rebase fixes * Do not force screenshot on dashboard alerts * feat: bypass cache on screenshots for alerts * Update existing tests * Add tests * feat: configure force_screenshot
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* Update existing tests * Add backend test * feat: add force option to report screenshots * Add tests * Rebase fixes * Do not force screenshot on dashboard alerts * feat: bypass cache on screenshots for alerts * Update existing tests * Add tests * feat: configure force_screenshot
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow users to force a screenshot (bypass the cache) on reports that send charts.
We're not enabling this for dashboards yet, since it still needs backend support.
For alerts, this is always on for charts, and off for dashboards (for perf reasons, and also because it's not implemented).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
force_screenshotis updated accordingly in the DB, or run celery and check that screenshot URLs haveforce=trueorforce=false.ADDITIONAL INFORMATION