chore:migrate ResultSet from class components to functional components #18821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-github-bot
bot
added
the
Superset-Community-Partners
|
@The-hyphen-user Hi, we already have the same #18593 PR |
AAfghahi
requested changes
Feb 22, 2022
| displayLimit, | ||
| height, | ||
| query, | ||
| search, |
There was a problem hiding this comment.
it seems like this has a default value, which you should put in. Same with database, csv, showSql, and visualize.
| ); | ||
| }; | ||
|
|
||
| ResultSet.defaultProps = { |
There was a problem hiding this comment.
I think you can move this in favor of stating defaults in the functional component itself.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
|
Superseded by #21186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
changed class components to functional
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
testing file still needs to be updated to test use-effect instead of component did mount/ component will receive props
ADDITIONAL INFORMATION