chore: refactor ResultSet to functional component #21186

EugeneTorap · 2022-08-24T17:46:22Z

SUMMARY

Converted ResultSet class component into functional component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

github-actions · 2022-08-24T18:53:46Z

Storybook has completed and can be viewed at

lyndsiWilliams

Hi, thanks for the conversion! I found a few things that need to be adjusted - also now that this component is functional, its test file will need to be converted to React Testing Library so that the frontend tests can pass.

superset-frontend/src/SqlLab/components/ResultSet/index.tsx

github-actions · 2022-08-25T03:18:45Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T03:35:46Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T03:48:31Z

Storybook has completed and can be viewed at

codecov · 2022-08-25T04:06:45Z

Codecov Report

Merging #21186 (684b5fc) into master (0c87ff7) will increase coverage by 0.01%.
The diff coverage is 57.39%.

❗ Current head 684b5fc differs from pull request most recent head cf55134. Consider uploading reports for the commit cf55134 to get more accurate results

@@            Coverage Diff             @@
##           master   #21186      +/-   ##
==========================================
+ Coverage   66.41%   66.42%   +0.01%     
==========================================
  Files        1784     1784              
  Lines       68185    68196      +11     
  Branches     7265     7270       +5     
==========================================
+ Hits        45284    45301      +17     
+ Misses      21032    21027       -5     
+ Partials     1869     1868       -1

Flag	Coverage Δ
javascript	`52.52% <57.39%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...lLab/components/ExploreCtasResultsButton/index.tsx	`8.33% <0.00%> (ø)`
...c/SqlLab/components/ExploreResultsButton/index.tsx	`100.00% <ø> (ø)`
...rontend/src/SqlLab/components/QueryTable/index.tsx	`70.17% <ø> (ø)`
...frontend/src/SqlLab/components/SouthPane/index.tsx	`66.66% <ø> (ø)`
...-frontend/src/components/FilterableTable/index.tsx	`72.63% <ø> (+0.29%)`	⬆️
...frontend/src/SqlLab/components/ResultSet/index.tsx	`56.41% <59.09%> (+4.70%)`	⬆️
...rset-frontend/src/components/ProgressBar/index.tsx	`80.00% <100.00%> (ø)`
superset-frontend/src/SqlLab/actions/sqlLab.js	`61.64% <0.00%> (+0.26%)`	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-08-25T09:14:04Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T10:15:14Z

Storybook has completed and can be viewed at

github-actions · 2022-08-25T11:04:34Z

Storybook has completed and can be viewed at

superset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.tsx

superset-frontend/src/SqlLab/components/ResultSet/index.tsx

lyndsiWilliams

Looks good! Thanks for the conversion, this is great 😁

lyndsiWilliams · 2022-08-30T00:16:22Z

/testenv up

github-actions · 2022-08-30T00:18:36Z

@lyndsiWilliams Ephemeral environment spinning up at http://54.188.192.217:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

hughhhh

Can we have some additional testing from QA before merging

jinghua-qa · 2022-08-30T15:59:12Z

Sure, love to test it!

kgabryje · 2022-08-31T14:19:12Z

/testenv up

github-actions · 2022-08-31T14:35:51Z

@kgabryje Ephemeral environment spinning up at http://35.86.88.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje · 2022-08-31T14:51:50Z

/testenv up

github-actions · 2022-08-31T16:36:47Z

@kgabryje Ephemeral environment spinning up at http://35.91.158.0:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje · 2022-09-01T15:54:21Z

The changes look good to me. @jinghua-qa Would you like to test it? The test env http://35.91.158.0:8080/ contains a fix for diappearing results when switching tabs

andrey-zayats · 2022-09-06T13:47:21Z

QA tested and verified. LGTM

EugeneTorap · 2022-09-06T14:09:30Z

@kgabryje @lyndsiWilliams @hughhhh Can we merge it?

QA done

kgabryje · 2022-09-06T14:54:58Z

@hughhhh I've overriden your change request since it was about waiting for QA, and that's done. Thanks @andrey-zayats !

github-actions · 2022-09-06T15:19:54Z

Ephemeral environment shutdown and build artifacts deleted.

…)" This reverts commit f603295.

EugeneTorap added 3 commits August 24, 2022 20:31

chore: refactor ResultSet to functional component

a4412f8

Fix bugs

37d68c6

Refactoring

7d21ad4

pull-request-size bot added the size/XL label Aug 24, 2022

lyndsiWilliams requested changes Aug 24, 2022

View reviewed changes

EugeneTorap added 2 commits August 25, 2022 06:05

Refactoring

22fd203

Refactoring styles

8998d04

EugeneTorap requested a review from lyndsiWilliams August 25, 2022 03:21

Refactoring actions

6058205

EugeneTorap added 7 commits August 25, 2022 08:30

Refactoring actions

4fa4bad

Refactoring tests

d9ba9fc

Refactoring tests

e248931

Refactoring tests

8c3408b

Refactoring tests

19acdc2

Refactoring tests

3fd5cbb

Refactoring tests

75c9671

pull-request-size bot added size/XXL and removed size/XL labels Aug 25, 2022

EugeneTorap added 2 commits August 25, 2022 10:34

Refactoring

e1f240f

Fix tests

e32e0db

kgabryje reviewed Aug 25, 2022

View reviewed changes

superset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.tsx Outdated Show resolved Hide resolved

kgabryje reviewed Aug 25, 2022

View reviewed changes

superset-frontend/src/SqlLab/components/ResultSet/index.tsx Outdated Show resolved Hide resolved

Fix act errors

a5e6079

EugeneTorap requested a review from lyndsiWilliams August 29, 2022 19:35

lyndsiWilliams approved these changes Aug 29, 2022

View reviewed changes

hughhhh self-requested a review August 30, 2022 00:23

hughhhh previously requested changes Aug 30, 2022

View reviewed changes

hughhhh added the need:qa-review Requires QA review label Aug 30, 2022

Merge branch 'master' into refactor/ResultSet-to-fc

cf55134

kgabryje merged commit f603295 into apache:master Sep 6, 2022

EugeneTorap deleted the refactor/ResultSet-to-fc branch September 6, 2022 14:57

kgabryje mentioned this pull request Sep 7, 2022

chore:migrate ResultSet from class components to functional components #18821

Closed

9 tasks

sadpandajoe added a commit to preset-io/superset that referenced this pull request Oct 4, 2022

Revert "chore: refactor ResultSet to functional component (apache#21186…

a169ed1

…)" This reverts commit f603295.

lyndsiWilliams mentioned this pull request Oct 4, 2022

fix(sqllab): Async queries are now fetched properly #21698

Merged

9 tasks

justinpark mentioned this pull request Feb 6, 2023

fix(sqllab): regression of clearQueryResults #23007

Closed

9 tasks

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: refactor ResultSet to functional component #21186

chore: refactor ResultSet to functional component #21186

EugeneTorap commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

lyndsiWilliams left a comment

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

codecov bot commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

lyndsiWilliams left a comment

lyndsiWilliams commented Aug 30, 2022

github-actions bot commented Aug 30, 2022

hughhhh left a comment

jinghua-qa commented Aug 30, 2022

kgabryje commented Aug 31, 2022

github-actions bot commented Aug 31, 2022

kgabryje commented Aug 31, 2022

github-actions bot commented Aug 31, 2022

kgabryje commented Sep 1, 2022

andrey-zayats commented Sep 6, 2022

EugeneTorap commented Sep 6, 2022 •

edited

Loading

kgabryje commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

chore: refactor ResultSet to functional component #21186

chore: refactor ResultSet to functional component #21186

Conversation

EugeneTorap commented Aug 24, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

github-actions bot commented Aug 24, 2022

lyndsiWilliams left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

codecov bot commented Aug 25, 2022 • edited Loading

Codecov Report

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

lyndsiWilliams left a comment

Choose a reason for hiding this comment

lyndsiWilliams commented Aug 30, 2022

github-actions bot commented Aug 30, 2022

hughhhh left a comment

Choose a reason for hiding this comment

jinghua-qa commented Aug 30, 2022

kgabryje commented Aug 31, 2022

github-actions bot commented Aug 31, 2022

kgabryje commented Aug 31, 2022

github-actions bot commented Aug 31, 2022

kgabryje commented Sep 1, 2022

andrey-zayats commented Sep 6, 2022

EugeneTorap commented Sep 6, 2022 • edited Loading

kgabryje commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

codecov bot commented Aug 25, 2022 •

edited

Loading

EugeneTorap commented Sep 6, 2022 •

edited

Loading