fix: Dashboard import holding issue #19112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemaster08240328
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19112 +/- ##
==========================================
- Coverage 66.59% 66.58% -0.01%
==========================================
Files 1676 1677 +1
Lines 64191 64240 +49
Branches 6525 6538 +13
==========================================
+ Hits 42746 42775 +29
- Misses 19746 19766 +20
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Mar 18, 2022
rusackas
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Looks like everything was addressed, aside from error display location, which we can tackle in a subsequent PR. There was also the issue of memoization that Diego found, if you want to capture that in a new ticket, @codemaster08240328
Thanks for the fix!
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 6, 2022
* fix dashboard import holding issue * resolve comment (cherry picked from commit e118b4d)
|
🏷️ preset:2022.13 |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix dashboard import holding issue * resolve comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Dashboard Import UI hangs when the operation fails - no error message is thrown to let the user know about it.
Behavior before update
The operation hangs. However, if you monitor the Network tab on the browser’s developer tools, you can check that the import request fails with a 500 error (Internal Server Error).
Expected results
The operation should thrown an error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION