-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: have user go to explore after dataset creation #19965
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19965 +/- ##
==========================================
- Coverage 66.85% 66.85% -0.01%
==========================================
Files 1753 1753
Lines 65827 65835 +8
Branches 7006 7007 +1
==========================================
+ Hits 44010 44011 +1
- Misses 20031 20037 +6
- Partials 1786 1787 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.217.36.72:8080. Credentials are |
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.222.46.113:8080. Credentials are |
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.216.189.219:8080. Credentials are |
Two things I noticed:
cc @jess-dillard if you want to test on the ephemeral & for feedback on point 2 |
Agreed with @yousoph, let's make those changes. |
…ack-datasetmodal-update
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This pr creates a new flow from the dataset modal where after user creates a datasource it directs them to the explore page.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
Screen.Recording.2022-05-10.at.12.09.41.PM.mov
TESTING INSTRUCTIONS
Go to create dataset and save. It should direct you to explore page.
ADDITIONAL INFORMATION