Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have user go to explore after dataset creation #19965

Merged
merged 9 commits into from
Jul 12, 2022
Merged

feat: have user go to explore after dataset creation #19965

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38416c9
feat: have user go to explore after dataset creation
pkdotson May 5, 2022
2b626af
change flow to create chart
pkdotson May 6, 2022
17dbb7e
fix lint
pkdotson May 10, 2022
eaaa58e
Merge branch 'master' of https://github.com/preset-io/superset into h…
pkdotson Jul 7, 2022
1e168e1
update with suggestions and add store for toasts
pkdotson Jul 8, 2022
f944e20
fix ts
pkdotson Jul 8, 2022
43a845b
fix test
pkdotson Jul 11, 2022
639727d
Merge branch 'master' of https://github.com/preset-io/superset into h…
pkdotson Jul 11, 2022
a2cede3
lint
pkdotson Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions superset-frontend/src/addSlice/AddSliceContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
import React, { ReactNode } from 'react';
import rison from 'rison';
import querystring from 'query-string';
import { styled, t, SupersetClient, JsonResponse } from '@superset-ui/core';
import Button from 'src/components/Button';
import { Select, Steps } from 'src/components';
Expand All @@ -27,6 +28,7 @@ import { Tooltip } from 'src/components/Tooltip';
import VizTypeGallery, {
MAX_ADVISABLE_VIZ_GALLERY_WIDTH,
} from 'src/explore/components/controls/VizTypeControl/VizTypeGallery';
import _ from 'lodash';

type Dataset = {
id: number;
Expand All @@ -40,6 +42,7 @@ export type AddSliceContainerProps = {};
export type AddSliceContainerState = {
datasource?: { label: string; value: string };
visType: string | null;
datasetName?: string | string[] | null;
};

const ESTIMATED_NAV_HEIGHT = 56;
Expand Down Expand Up @@ -194,6 +197,16 @@ export default class AddSliceContainer extends React.PureComponent<
this.loadDatasources = this.loadDatasources.bind(this);
}

componentDidMount() {
const params = querystring.parse(window.location.search)?.dataset as string;
if (params) {
this.loadDatasources(params, 0, 1).then(r => {
const datasource = r.data[0];
this.setState({ datasource });
});
}
}

exploreUrl() {
const formData = encodeURIComponent(
JSON.stringify({
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ const DatasetModal: FunctionComponent<DatasetModalProps> = ({
onDatasetAdd({ id: response.id, ...response });
}
addSuccessToast(t('The dataset has been saved'));
window.location.href = `/chart/add?dataset=${currentTableName}`;
hide();
});
};
Expand All @@ -116,7 +117,7 @@ const DatasetModal: FunctionComponent<DatasetModalProps> = ({
disablePrimaryButton={disableSave}
onHandledPrimaryAction={onSave}
onHide={hide}
primaryButtonName={t('Add')}
primaryButtonName={t('Add Dataset and Create Chart')}
show={show}
title={t('Add dataset')}
>
Expand Down