Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added new translations to the spanish language #20427

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

cdpazos27
Copy link
Contributor

@cdpazos27 cdpazos27 commented Jun 17, 2022

SUMMARY

Added new translations for Spanish Language - Specifically on the visualizations of Time-Series in the Spanish Language

(It's my first time creating a PR in this project, if any information is missing, please let me know)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1 - Start dev server with all default configs and examples
2 - Select Language -> Spanish
3 - Create a new Visualization

Now the Time-Series visualizations should have their descriptions and title updated, in spanish

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #20427 (a6a8fc0) into master (467d8ef) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20427      +/-   ##
==========================================
- Coverage   66.70%   66.67%   -0.04%     
==========================================
  Files        1739     1739              
  Lines       65135    65137       +2     
  Branches     6897     6897              
==========================================
- Hits        43450    43429      -21     
- Misses      19932    19955      +23     
  Partials     1753     1753              
Flag Coverage Δ
hive 53.70% <ø> (+<0.01%) ⬆️
mysql 82.28% <ø> (-0.02%) ⬇️
postgres ?
presto 53.56% <ø> (+<0.01%) ⬆️
python 82.71% <ø> (-0.08%) ⬇️
sqlite 82.13% <ø> (+0.04%) ⬆️
unit 50.54% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/sql_validators/__init__.py 80.00% <0.00%> (-20.00%) ⬇️
superset/db_engine_specs/postgres.py 91.52% <0.00%> (-5.09%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/databases/commands/validate_sql.py 92.00% <0.00%> (-2.00%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/common/query_object.py 94.73% <0.00%> (-0.53%) ⬇️
superset/views/base_api.py 97.97% <0.00%> (-0.41%) ⬇️
superset/reports/commands/execute.py 91.24% <0.00%> (-0.37%) ⬇️
superset/databases/api.py 95.17% <0.00%> (-0.33%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467d8ef...a6a8fc0. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 364bb7c into apache:master Jun 28, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* Added new translations for Spanish Language - Specifically on the visualizations of Time-Series

* Chore: Added more translations to the Time-Series visualizations
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants