Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error when saving datasource from Explore #20749

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix: Error when saving datasource from Explore #20749

merged 1 commit into from
Jul 18, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes an error when saving the datasource from Explore.

Follow-up of #20645

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-07-18.at.10.43.55.AM.mov
Screen.Recording.2022-07-18.at.1.17.49.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

kgabryje
kgabryje approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #20749 (38e0624) into master (776d211) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master   #20749      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files        1754     1754              
  Lines       66673    66678       +5     
  Branches     7049     7049              
==========================================
+ Hits        44249    44250       +1     
- Misses      20627    20631       +4     
  Partials     1797     1797
Flag Coverage Δ
javascript 51.92% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/components/controls/DatasourceControl/index.jsx 75.24% <0.00%> (ø)
...et-frontend/src/explore/reducers/exploreReducer.js 39.34% <0.00%> (-0.66%) ⬇️
...set-frontend/src/explore/actions/exploreActions.ts 47.72% <25.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776d211...38e0624. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 92f3621 into apache:master Jul 18, 2022
michael-s-molina added a commit to michael-s-molina/superset that referenced this pull request Jul 20, 2022
@michael-s-molina
Revert "fix: Error when saving datasource from Explore (apache#20749)"
c2d2512 
This reverts commit 92f3621.
@michael-s-molina michael-s-molina mentioned this pull request Jul 20, 2022
Merged
9 tasks
michael-s-molina added a commit that referenced this pull request Jul 20, 2022
@michael-s-molina
fix: Reverts #20749 and #20645 (#20796)
3311128 
* Revert "fix: Error when saving datasource from Explore (#20749)"

This reverts commit 92f3621.

* Revert "refactor: Unify shared datasources reducers and actions (#20645)"

This reverts commit 2a70540.
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 21, 2022
@michael-s-molina @sadpandajoe
fix: Reverts apache#20749 and apache#20645 (apache#20796)
e4916de 
* Revert "fix: Error when saving datasource from Explore (apache#20749)"

This reverts commit 92f3621.

* Revert "refactor: Unify shared datasources reducers and actions (apache#20645)"

This reverts commit 2a70540.

(cherry picked from commit 3311128)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch