Skip to content

Commit

Permalink
Revert "fix: Error when saving datasource from Explore (apache#20749)"
Browse files Browse the repository at this point in the history
This reverts commit 92f3621.
  • Loading branch information
michael-s-molina committed Jul 20, 2022
1 parent 5a04a28 commit c2d2512
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
8 changes: 0 additions & 8 deletions superset-frontend/src/explore/actions/exploreActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,6 @@ export function setForceQuery(force: boolean) {
};
}

export const SAVE_DATASOURCE = 'SAVE_DATASOURCE';
export function saveDatasource(datasource: Dataset) {
return function (dispatch: Dispatch) {
dispatch(setDatasource(datasource));
dispatch({ type: SAVE_DATASOURCE, datasource });
};
}

export function changeDatasource(newDatasource: Dataset) {
return function (dispatch: Dispatch, getState: () => ExplorePageState) {
const {
Expand Down
13 changes: 0 additions & 13 deletions superset-frontend/src/explore/reducers/exploreReducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,6 @@ export default function exploreReducer(state = {}, action) {
isDatasourceMetaLoading: true,
};
},
[actions.SAVE_DATASOURCE]() {
return {
...state,
datasource: action.datasource,
controls: {
...state.controls,
datasource: {
...state.controls.datasource,
datasource: action.datasource,
},
},
};
},
[actions.UPDATE_FORM_DATA_BY_DATASOURCE]() {
const newFormData = { ...state.form_data };
const { prevDatasource, newDatasource } = action;
Expand Down

0 comments on commit c2d2512

Please sign in to comment.