fix(db): set slices.query_context to MEDIUMTEXT for mysql #20779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up for #20761, changing
Slice.query_context
andSlice.params
toMEDIUMTEXT
for MySQL databases. Ideally this should be ran before #20359 and #20346 but that would mean rebasing the existing migrations, which could be problematic for users who already ran both migrations.We'll just accept the risk that some MySQL users may lose
query_context
data if they didn't manually run this column type change before #20359 and #20346...On Airbnb's Superset instance with about 350k slices, this migration completes in about 50 seconds.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION