-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Area viz migration #20359
feat: Area viz migration #20359
Conversation
63ceece
to
3be4d43
Compare
Codecov Report
@@ Coverage Diff @@
## master #20359 +/- ##
==========================================
+ Coverage 66.78% 66.85% +0.07%
==========================================
Files 1754 1754
Lines 65857 65748 -109
Branches 7030 6950 -80
==========================================
- Hits 43982 43957 -25
+ Misses 20086 20028 -58
+ Partials 1789 1763 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3be4d43
to
e40d62a
Compare
slc.slice_name, str(exc) | ||
) | ||
) | ||
session.commit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this commit only after all the values have been merged as opposed to committing every thousand values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the TreeMap migration, optimize write speed.
The yield_per
just optimizes the memory used rate when retrieving large data, the commit()
only run one time after the update.
e40d62a
to
b6102c5
Compare
@zhaoyongjie would you mind explaining the purpose of this migration if the "Area Chart" chart type still exists? Is the intention to fully deprecate said chart type? If so this migration would need to be re-run. |
@john-bodley Sorry, I'm stuck in another PR with a cypress problem. I think the migration process should be re-run after resolve the frontend migration issue. |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION