Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: suppress flask_appbuilder logs in CI #20870

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jul 26, 2022

SUMMARY

FAB and SQL throws a lot of non-essential logs upon app initialization which makes it harder to see actual error logs from tests.

I think I'd make sense to suppress such logs as if there's anything wrong with them, other parts of the app will throw errors anyway.

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Check CI logs

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie self-requested a review July 26, 2022 16:40
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20870 (e01a69a) into master (a69f016) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20870   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files        1757     1757           
  Lines       66962    66962           
  Branches     7109     7109           
=======================================
  Hits        44380    44380           
  Misses      20767    20767           
  Partials     1815     1815           
Flag Coverage Δ
hive 53.26% <ø> (ø)
mysql 81.07% <ø> (ø)
postgres 81.14% <ø> (ø)
presto 53.12% <ø> (ø)
python 81.59% <ø> (ø)
sqlite 79.76% <ø> (ø)
unit 50.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ktmud
Copy link
Member Author

ktmud commented Jul 26, 2022

Confirmed the logs are now nice and clean.

@ktmud ktmud merged commit 6e6d4e3 into apache:master Jul 26, 2022
@john-bodley john-bodley deleted the suppress-fab-logs-in-tests branch February 17, 2023 22:16
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants