-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip row if created_at_fk is null #20939
fix: skip row if created_at_fk is null #20939
Conversation
@john-bodley this should fix the issue that @AAfghahi was reporting on #20617. I'm trying to get a test if possible, but I was able to test this locally. |
Codecov Report
@@ Coverage Diff @@
## master #20939 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1766 1766
Lines 67225 67225
Branches 7135 7135
=======================================
Hits 44626 44626
Misses 20774 20774
Partials 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
I'm going to merge this without a test, and I'm looking into a longer-term solution around alembic migration tests, possibly https://pypi.org/project/pytest-alembic/ |
33c0dc6
to
fc55ac3
Compare
(cherry picked from commit fb5f8ca)
Some migrations are failing for
ffa79af61a56
when a created_by_fk is blank for a dataset. This PR skips that row if nullTESTING INSTRUCTIONS
TBD
ADDITIONAL INFORMATION