Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Fix tab state #20947

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This enables queryEditors to check for name and title.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #20947 (c9c6c10) into master (bfd2a3d) will decrease coverage by 0.04%.
The diff coverage is 54.16%.

❗ Current head c9c6c10 differs from pull request most recent head 831197f. Consider uploading reports for the commit 831197f to get more accurate results

@@            Coverage Diff             @@
##           master   #20947      +/-   ##
==========================================
- Coverage   66.38%   66.33%   -0.05%     
==========================================
  Files        1766     1766              
  Lines       67207    67225      +18     
  Branches     7129     7135       +6     
==========================================
- Hits        44617    44597      -20     
- Misses      20766    20803      +37     
- Partials     1824     1825       +1     
Flag Coverage Δ
hive 53.20% <100.00%> (+<0.01%) ⬆️
mysql 81.02% <100.00%> (+<0.01%) ⬆️
postgres ?
presto 53.10% <100.00%> (+<0.01%) ⬆️
python 81.48% <100.00%> (-0.09%) ⬇️
sqlite 79.67% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 31.25% <0.00%> (-4.47%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 54.65% <0.00%> (-1.31%) ⬇️
...tend/plugins/plugin-chart-echarts/src/constants.ts 100.00% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 9.67% <0.00%> (-0.50%) ⬇️
superset/datasets/schemas.py 97.33% <ø> (ø)
superset/views/sql_lab.py 60.52% <ø> (ø)
...tend/src/components/Datasource/CollectionTable.tsx 81.35% <100.00%> (+0.48%) ⬆️
...end/src/components/Datasource/DatasourceEditor.jsx 65.87% <100.00%> (+0.13%) ⬆️
...ponents/controls/ControlPopover/ControlPopover.tsx 89.09% <100.00%> (ø)
...rc/explore/components/controls/TextAreaControl.jsx 81.81% <100.00%> (+1.81%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing CI on master. We'll fast follow with a test

@lyndsiWilliams lyndsiWilliams merged commit c06d5eb into apache:master Aug 2, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/ci-fix branch August 2, 2022 22:09
@eschutho eschutho mentioned this pull request Aug 2, 2022
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants