Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Fix tab state #20947

Merged
merged 2 commits into from
Aug 2, 2022
Merged

fix(sqllab): Fix tab state #20947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923cc78
Fix tab state
lyndsiWilliams Aug 2, 2022
831197f
Update sql_lab.py
lyndsiWilliams Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/views/sql_lab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ def post(self) -> FlaskResponse: # pylint: disable=no-self-use
query_editor = json.loads(request.form["queryEditor"])
tab_state = TabState(
user_id=get_user_id(),
label=query_editor.get("title", "Untitled Query"),
# This is for backward compatibility
label=query_editor.get("name")
or query_editor.get("title", "Untitled Query"),
active=True,
database_id=query_editor["dbId"],
schema=query_editor.get("schema"),
Expand Down