Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Format the same size of picture for better part of "Supported Databases" document #21037

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

zhouyao1994
Copy link
Contributor

#21028 (comment)
No code change

type:png size:400*160

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[before]
image

[after]
image

zhouyao1994 and others added 5 commits January 5, 2019 22:42
delete the 'null,' in messages.json,
so that word can be translate in js.
� Conflicts:
�	superset/translations/zh/LC_MESSAGES/messages.json
…ify the aprt of "Supported dabase" in README
@zhouyao1994
Copy link
Contributor Author

@zhaoyongjie May be can hlep me review this 😊

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! @srinify how about you think?

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #21037 (6d1d6b7) into master (dfe5a04) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d1d6b7 differs from pull request most recent head 837c798. Consider uploading reports for the commit 837c798 to get more accurate results

@@           Coverage Diff           @@
##           master   #21037   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1769     1769           
  Lines       67470    67470           
  Branches     7170     7170           
=======================================
  Hits        44708    44708           
  Misses      20931    20931           
  Partials     1831     1831           
Flag Coverage Δ
javascript 52.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@srinify
Copy link
Contributor

srinify commented Aug 22, 2022

Love it, thanks for the contribution!

@srinify srinify merged commit ca98fd8 into apache:master Aug 22, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants