fetch remote #6
Merged
fetch remote #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Database Modal: - Add missing invocation to onDatabaseAdd after importing DB from file - Add keys to our IconButtons * Database Modal: - Reduce if clause so it's more concise
* chore: move isAdhocColumn to superset-ui/core * ut
* fix: Removes psycopg2 as a required dependency * Disables lint warning
…ge added through Markdown (#20362) * fix: Unable to download the Dashboard as image in case there's an image added through Markdown * licence
…rnal form values (#20487)
* add setupExtensions * add 'navbar.right' extension to registry * add test for navbar.right extension point * rename MenuRight -> RightMenu * lint
…ata (#20519) * feat(explore): Use v1/explore endpoint data instead of bootstrapData * Add tests * Fix ci * Remove redundant dependency * Use form_data_key in cypress tests * Add auth headers to for data request * Address comments * Remove displaying danger toast * Conditionally add auth headers * Address comments * Fix typing bug * fix * Fix opening dataset * Fix sqllab chart create * Run queries in parallel * Fix dashboard id autofill * Fix lint * Fix test
* Respecting max/min opacities, and adding tests. * revising tests * Adding missing test case for maximum coverage :) * removing unnecessary logic and test * adding another unit test for (hopefully) full coverage. * no more ternary operator * New approach with Math.min - take THAT codecov. * one more stab at making codecov happy... ignoring the file next. * lint fixes
* welcome top extension * show database modal * add test * Delete lines.svg * rename to banner * remove lines Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
…n overwritting (#20512) * Save Dataset Modal: - Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app - Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting - We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected - Updated tests * Save Dataset Modal: - Update missing test for DatasourceControl * Save Dataset Modal: - Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application * Save Dataset Modal: - Remove unused comment * Save Dataset Modal: - Add getPopupContainer as prop for Select component * Save Dataset Modal: - Add tests for our new getPopupContainer prop in Select component. So if passed it gets called. * Save Dataset Modal: - use lowercased property when calling post form data * Save Dataset Modal: - Update tests so there is no need to define a null returning func * Save Dataset Modal: - Including getPopupContainer from PickedSelectProps instead - Updating definition in SelectFilterPlugin
…ent (#20256) * Revert "Superset - Release and Improvements (12-05-2022)" * merging conflic changes * Revert "Revert "Superset - Release and Improvements (12-05-2022)"" This reverts commit 6d18661. * fixed breaking changes * sync with master * fixed breaking flows * fixed getUISchema function call * added default placeholder and updated docs * fixed format and comments * changed flag to configuration * fix: indentation of SCHEDULED_QUERIES dict * fix: changed intendation for SCHEDULED_QUERIES * fix: updated docs for SCHEDULED_QUERIES * fix: replaced button to menu item for SCHEDULED_QUERIES * fix: updated docs for SCHEDULED_QUERIES * fix: trailing whitespace
* add flow for dbconnmodal to datasetmodal * fix bug * second part * fix dataset to sql lab * fix lint * more lint * add key value * fix type * add new styling * remove undefined from types
* chore(rls): Remove passing global username * Update manager.py * Update manager.py * Update manager.py * Update manager.py Co-authored-by: John Bodley <john.bodley@airbnb.com>
* back button fix * fixed test
* add timegrains to data payload * fix * opps * save * integrate type casting for engiines * add perm object * change how wwe raise_for_access * fix orderby on column types * linting
* fix: remove extra line for link * add space
…iles (#20920) * chore: make dependabot upgrade package.json, and add more package.json files to the mix. * trailing newline
* debugging columns * Clean up code * Fix test
* fix * save * integrate type casting for engiines * fix orderby on column types * fixes Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* add 'dashboard.nav.right' extension to registry * add test
Bumps [cookie-parser](https://github.com/expressjs/cookie-parser) from 1.4.5 to 1.4.6. - [Release notes](https://github.com/expressjs/cookie-parser/releases) - [Changelog](https://github.com/expressjs/cookie-parser/blob/master/HISTORY.md) - [Commits](expressjs/cookie-parser@1.4.5...1.4.6) --- updated-dependencies: - dependency-name: cookie-parser dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…20980) Bumps [debug](https://github.com/debug-js/debug) from 4.3.2 to 4.3.4. - [Release notes](https://github.com/debug-js/debug/releases) - [Commits](debug-js/debug@4.3.2...4.3.4) --- updated-dependencies: - dependency-name: debug dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…re (#20972) * fix(explore): Replace url search params only if current page is Explore * Add unit test
…20979) Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.1. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.18.1) --- updated-dependencies: - dependency-name: express dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* save dataset and repopulate state * disable dashboard button if dataset is missing * fix error message * fix tests
* chore: update text for dbconn modal * fix text and close opts for adddataset modal * update loading state, add state change for cta btns, and styling * remove space
* feat: per-db add metrics * Add unit tests
* feat(helm): add liveness and readiness for deployment webserver * feat(helm): add example in values * feat(helm): move config probes under supersetNode * feat(helm): bump chart.yaml * fix(helm): remove default values in template and use values.yaml * fix(git): bump chart verison * fix(json): update the schema to get CI passing * fix(helm): correct path for values readiness Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Co-authored-by: Jeremy PLANCKEEL <jplanckeel.externe@bedrockstreaming.com> Co-authored-by: Craig Rueda <craig@craigrueda.com> Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
…0807) * Update properties tests * Update selectors * Verify charts changing colors * Test shared and label colors * Update dashboard edit test * Enhance viz tests * Remove chart ids * Update color
…20974) * Implement model specific lookups by id to improve performance * Address comments e.g. better variable names and test cleanup * commit after cleanup * even better name and test cleanup via rollback Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
…20891) * feat: Adds drill to detail context menu for ECharts visualizations * Rebases and adds time grain * Fixes selected gauge values * Fixes Treemap edge click * Adds right click to big number trendline * Address some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS