Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(viz): rename v1 and v2 charts #22369

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 8, 2022

SUMMARY

This makes the "v2" charts the "official ones" by removing the version suffix, and add "(legacy)" to the old ones that they're replacing.

AFTER

Now the viz switcher doesn't feature the v2 name (here I'm using generic x-axis):
image

BEFORE

Currently many charts feature a "v2" suffix:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #22369 (ad5016d) into master (3a442e0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #22369   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files        1847     1847           
  Lines       70562    70562           
  Branches     7742     7742           
=======================================
  Hits        47179    47179           
  Misses      21382    21382           
  Partials     2001     2001           
Flag Coverage Δ
javascript 53.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-pivot-table/src/index.js 66.66% <ø> (ø)
...d/plugins/legacy-plugin-chart-treemap/src/index.js 66.66% <ø> (ø)
...plugins/legacy-preset-chart-nvd3/src/Area/index.js 66.66% <ø> (ø)
.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js 66.66% <ø> (ø)
...plugins/legacy-preset-chart-nvd3/src/Line/index.js 66.66% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/Area/index.ts 33.33% <ø> (ø)
...-chart-echarts/src/Timeseries/Regular/Bar/index.ts 33.33% <0.00%> (ø)
...chart-echarts/src/Timeseries/Regular/Line/index.ts 33.33% <ø> (ø)
.../plugins/plugin-chart-echarts/src/Treemap/index.ts 50.00% <ø> (ø)
...ugins/plugin-chart-pivot-table/src/plugin/index.ts 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the good housekeeping!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@villebro villebro merged commit 012d130 into apache:master Dec 9, 2022
@michael-s-molina
Copy link
Member

@rusackas This PR will probably require an update to Preset docs as the v2 suffix is referenced on some pages and there's no legacy suffix currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants