chore(viz): Rename legacy non-time-series Bar Chart #22430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Dec 15, 2022
| @@ -35,7 +35,7 @@ const metadata = new ChartMetadata({ | |||
| { url: example2, caption: 'Grouped style' }, | |||
| { url: example3 }, | |||
| ], | |||
| name: t('Bar Chart'), | |||
| name: t('Bar Chart (legacy)'), | |||
There was a problem hiding this comment.
I think it might make sense to make this conditional on the feature flag being flipped (<feature flag check> ? 'Bar Chart (legacy)' : 'Bar Chart';), as an env that's not using generic x-axis will not have an alternative to the legacy bar chart.
Codecov Report
@@ Coverage Diff @@
## master #22430 +/- ##
==========================================
- Coverage 66.91% 66.90% -0.02%
==========================================
Files 1850 1850
Lines 70695 70693 -2
Branches 7750 7752 +2
==========================================
- Hits 47309 47295 -14
- Misses 21370 21382 +12
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
codyml
force-pushed
the
chore/rename-bar-chart
branch
from
4df9e18 to
ace1212
Compare
9 tasks
codyml
force-pushed
the
chore/rename-bar-chart
branch
2 times, most recently
from
b7c5401 to
50cba02
Compare
…CI; trigger CI; trigger CI.
codyml
force-pushed
the
chore/rename-bar-chart
branch
from
50cba02 to
3c41e19
Compare
This was referenced Jan 3, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As a follow-up to #22369, this PR renames the legacy non-time-series Bar Chart to Bar Chart (legacy). There is both a legacy Bar Chart and a legacy Time-series Bar Chart along with the non-legacy Time-series Bar Chart. When
GENERIC_CHART_AXESis on, the non-legacy Time-series Bar Chart is displayed as just Bar Chart, so both the new and the old Bar Chart currently end up with the same name.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
GENERIC_CHART_AXESis on and when it's off.ADDITIONAL INFORMATION
GENERIC_CHART_AXES