fix(dashboard): Focusing charts and native filters from filters badge

[kgabryje]

SUMMARY

This PR addresses 2 bugs:

1. When user applied cross filters in the dashboard and then clicked the search icon in filters badge, the whole dashboard would go grey and become non-interactive. The only way to fix it was to refresh the dashboard.
2. When user applied native filters and then clicked on a search icon in filters badge, the native filter would get highlighted (correctly) but also all charts in scope of that filter would get highlighted. That behaviour is desired only when user manually hovers or focuses the native filter, not when they want to see which native filter is affecting given chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2023-02-24.at.15.01.06.mov

After:

Screen.Recording.2023-02-24.at.14.56.20.mov

TESTING INSTRUCTIONS

1. Open a dashboard and apply a cross filter
2. Verify that the search icon in filters badge focuses the emitter chart (should also change the tab and scroll the chart into view if necessary)
3. Apply a native filter
4. Verify that the search icon in filters badge focuses the native filter. Charts in scope of that filter should not be highlighted unless user manually focuses the native filter or hovers over it.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23190 (1383266) into master (ee1952e) will increase coverage by 0.04%.
The diff coverage is 60.10%.

❗ Current head 1383266 differs from pull request most recent head 2c8aca0. Consider uploading reports for the commit 2c8aca0 to get more accurate results

@@            Coverage Diff             @@
##           master   #23190      +/-   ##
==========================================
+ Coverage   67.42%   67.46%   +0.04%     
==========================================
  Files        1899     1900       +1     
  Lines       73154    73108      -46     
  Branches     7959     7903      -56     
==========================================
  Hits        49323    49323              
+ Misses      21796    21760      -36     
+ Partials     2035     2025      -10     

Flag	Coverage Δ
javascript	53.65% <48.78%> (+0.08%)	⬆️
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <ø> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx	74.00% <ø> (-0.51%)	⬇️
...src/dashboard/components/DashboardBuilder/state.ts	72.41% <ø> (-0.92%)	⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx	86.11% <0.00%> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx	55.45% <0.00%> (+1.06%)	⬆️
...Filters/FilterBar/FilterControls/FilterControl.tsx	28.57% <ø> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx	5.71% <0.00%> (-0.29%)	⬇️
.../components/nativeFilters/FilterBar/Horizontal.tsx	100.00% <ø> (ø)
...rd/components/nativeFilters/FilterBar/Vertical.tsx	74.50% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx	50.00% <ø> (ø)
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

LGTM and tested that it works as expected 👍

[villebro]

pure subjective and personal preference, but double .. always makes me cringe 😬

Suggested change

	import { setDirectPathToChild } from '../../actions/dashboardState';
	import { setDirectPathToChild } from 'src/dashboards/actions/dashboardState';

[kgabryje]

Same, fixed 🙂