chore: log different selenium timeout errors differently

[eschutho]

SUMMARY

There are three different places in Selenium screenshots where they can error. I'm logging each one differently so that we can track what's happening more granularly. I'm hoping that we can dig more into which of these issues are actionable from the system side and which take user/client action and log them accordingly (warn vs exception)

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23290 (ac013b6) into master (1f3eb56) will increase coverage by 0.01%.
The diff coverage is 70.79%.

❗ Current head ac013b6 differs from pull request most recent head 2c2a18b. Consider uploading reports for the commit 2c2a18b to get more accurate results

@@            Coverage Diff             @@
##           master   #23290      +/-   ##
==========================================
+ Coverage   67.51%   67.52%   +0.01%     
==========================================
  Files        1907     1909       +2     
  Lines       73435    73503      +68     
  Branches     7977     7988      +11     
==========================================
+ Hits        49579    49634      +55     
- Misses      21804    21819      +15     
+ Partials     2052     2050       -2     

Flag	Coverage Δ
hive	52.76% <61.11%> (+0.02%)	⬆️
mysql	78.42% <84.72%> (+<0.01%)	⬆️
postgres	78.49% <84.72%> (+<0.01%)	⬆️
presto	52.68% <61.11%> (+0.04%)	⬆️
python	82.26% <84.72%> (+<0.01%)	⬆️
sqlite	76.96% <84.72%> (+<0.01%)	⬆️
unit	52.47% <19.44%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-ui-chart-controls/src/operators/sortOperator.ts	100.00% <ø> (ø)
...rt-controls/src/shared-controls/customControls.tsx	17.39% <0.00%> (-7.61%)	⬇️
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx	0.00% <0.00%> (ø)
...tend/plugins/plugin-chart-table/src/TableChart.tsx	45.16% <0.00%> (-0.25%)	⬇️
...Filters/FilterBar/FiltersDropdownContent/index.tsx	20.00% <ø> (ø)
...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx	14.28% <0.00%> (-2.39%)	⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx	8.79% <0.00%> (-0.10%)	⬇️
superset/common/query_context_processor.py	88.47% <ø> (ø)
superset/utils/webdriver.py	75.78% <47.36%> (-5.26%)	⬇️
superset/models/helpers.py	38.16% <66.66%> (+0.13%)	⬆️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[craig-rueda]

Maybe add a little more detail to these debug statements, such as the url in order to aid debugging?

[craig-rueda]

LGTM, except for a little more context added to the debug msgs

[eschutho]

These are most likely going to be network errors, i.e., server is down or url is incorrect, or perhaps permissions - user can't access the page.

[eschutho]

These imo are going to be client errors, and will show as errors on the dashboard when the user views it, not just in reports. This is an example where the client db is down. Also dataset role access will show these errors. There's a flag SCREENSHOT_REPLACE_UNEXPECTED_ERRORS to show better errors here in the screenshots.

[eschutho]

This is one area where I think a warning may make sense. @craig-rueda what do you think here?

[eschutho]

this error is going to be because the client db took too long to return the data. Some optimization is possible on either the client db or the superset instance to tune timeouts. Warning vs exception here is a little questionable.