fix: database dropdown keys

[betodealmeida]

SUMMARY

The latest ClickHouse driver comes with its own DB engine spec for Superset, which breaks the dropdown for selecting a database because the key in the select option is no longer unique. I fixed this by adding using the option index as the key, as well as renaming the Superset DB engine spec to "ClickHouse Connect (Superset)" to differentiate from the native DB engine spec.

In the future we should probably consider removing our ClickHouse Connect DB engine spec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23433 (fc6d485) into master (82cadcc) will decrease coverage by 1.52%.
The diff coverage is 80.17%.

❗ Current head fc6d485 differs from pull request most recent head b089ce7. Consider uploading reports for the commit b089ce7 to get more accurate results

@@            Coverage Diff             @@
##           master   #23433      +/-   ##
==========================================
- Coverage   67.48%   65.96%   -1.52%     
==========================================
  Files        1907     1908       +1     
  Lines       73442    73721     +279     
  Branches     7974     7989      +15     
==========================================
- Hits        49559    48629     -930     
- Misses      21835    23044    +1209     
  Partials     2048     2048              

Flag	Coverage Δ
hive	52.73% <45.08%> (-0.03%)	⬇️
mysql	78.45% <79.32%> (?)
postgres	78.51% <79.32%> (+0.03%)	⬆️
presto	?
python	78.85% <82.71%> (-3.34%)	⬇️
sqlite	77.02% <82.03%> (?)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rt-controls/src/shared-controls/customControls.tsx	17.39% <0.00%> (ø)
...-core/src/hooks/useChangeEffect/useChangeEffect.ts	100.00% <ø> (ø)
...hooks/useComponentDidMount/useComponentDidMount.ts	100.00% <ø> (ø)
...oks/useComponentDidUpdate/useComponentDidUpdate.ts	100.00% <ø> (ø)
...src/hooks/useElementOnScreen/useElementOnScreen.ts	100.00% <ø> (ø)
...erset-ui-core/src/hooks/usePrevious/usePrevious.ts	100.00% <ø> (ø)
...re/src/hooks/useTruncation/useCSSTextTruncation.ts	100.00% <ø> (ø)
...c/hooks/useTruncation/useChildElementTruncation.ts	100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts	100.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx	40.00% <ø> (ø)
... and 142 more

... and 61 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more