Skip to content

Commit

Permalink
fix: database dropdown keys (apache#23433)
Browse files Browse the repository at this point in the history
(cherry picked from commit 65a3a4d)
  • Loading branch information
betodealmeida authored and jinghua-qa committed Mar 20, 2023
1 parent 5cf5de9 commit 63dfa4d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -928,8 +928,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
?.sort((a: DatabaseForm, b: DatabaseForm) =>
a.name.localeCompare(b.name),
)
.map((database: DatabaseForm) => (
<AntdSelect.Option value={database.name} key={database.name}>
.map((database: DatabaseForm, index: number) => (
<AntdSelect.Option value={database.name} key={`database-${index}`}>
{database.name}
</AntdSelect.Option>
))}
Expand Down
2 changes: 1 addition & 1 deletion superset/db_engine_specs/clickhouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ class ClickHouseConnectEngineSpec(ClickHouseEngineSpec, BasicParametersMixin):
"""Engine spec for clickhouse-connect connector"""

engine = "clickhousedb"
engine_name = "ClickHouse Connect"
engine_name = "ClickHouse Connect (Superset)"

default_driver = "connect"
_function_names: List[str] = []
Expand Down

0 comments on commit 63dfa4d

Please sign in to comment.