-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add default empty array to filter dependencies #23565
Conversation
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #23565 +/- ##
=======================================
Coverage 67.70% 67.71%
=======================================
Files 1914 1914
Lines 73961 73994 +33
Branches 8029 8033 +4
=======================================
+ Hits 50076 50102 +26
- Misses 21838 21842 +4
- Partials 2047 2050 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also related: #23682 |
fix(filters): Add default empty array to filter
SUMMARY
Add default empty array to filter when
formFilter?.dependencies
andfilterToEdit?.cascadeParentIds
is null or undefinedBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Fixes #23564