Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for dependencies that could be undefined #23682

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: allow for dependencies that could be undefined #23682

merged 1 commit into from
Apr 13, 2023

Conversation

eschutho
Copy link
Member

SUMMARY

fixes if dependencies are undefined.. test to come

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jinghua-qa jinghua-qa merged commit 2625017 into apache:master Apr 13, 2023
@jinghua-qa jinghua-qa deleted the elizabeth/fix-filters branch April 13, 2023 19:01
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Apr 13, 2023
@eschutho @jinghua-qa
fix: allow for dependencies that could be undefined (apache#23682)
d100dc0 
(cherry picked from commit 2625017)
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Apr 14, 2023
@eschutho @jinghua-qa
fix: allow for dependencies that could be undefined (apache#23682)
bd39340 
(cherry picked from commit 2625017)
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@eschutho @sebastianliebscher
fix: allow for dependencies that could be undefined (apache#23682)
9d0b835
@eschutho eschutho mentioned this pull request Jun 6, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.13 preset:2023.15 size/XS 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eschutho @betodealmeida @mistercrunch @jinghua-qa