Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Add fullname prefix to init job #24221

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

NickLarsenNZ
Copy link
Contributor

@NickLarsenNZ NickLarsenNZ commented May 25, 2023

SUMMARY

Include the release name in the init db hook Job and Pod.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (without my-release- prefix) and after (with my-release- prefix) for Job and its child Pod resources:

image image

TESTING INSTRUCTIONS

helm dep update # this might not be needed, or might need to be done in the apache/superset/helm/superset directory

helm upgrade --install my-release ~/dev/github.com/apache/superset/helm/superset --namespace default

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Helm hook job doesn't include the release name #24219
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@NickLarsenNZ
Copy link
Contributor Author

@craig-rueda I'll bump the chart version once #24222 is merged (saves a merge-conflict, and potentially unknown next version depending on which would get merged first).

@NickLarsenNZ
Copy link
Contributor Author

@craig-rueda this is ready for review now

@craig-rueda craig-rueda merged commit 17e79ac into apache:master Jun 14, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm hook job doesn't include the release name
3 participants