Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): Use correct default hostnames for postgres and redis #24222

Merged
merged 2 commits into from
May 30, 2023
Merged

fix(helm): Use correct default hostnames for postgres and redis #24222

merged 2 commits into from
May 30, 2023

Conversation

NickLarsenNZ
Copy link
Contributor

@NickLarsenNZ NickLarsenNZ commented May 25, 2023 •
edited
Loading

SUMMARY

Render the correct hostname for the default postgres and redis services.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Secret resource:

image

Service resources:

image

TESTING INSTRUCTIONS

helm upgrade --install my-release ~/dev/github.com/apache/superset/helm/superset --namespace default
helm upgrade --install my-release ~/dev/github.com/apache/superset/helm/superset --namespace default --set nameOverride="foo" --set fullnameOverride="bar"

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Helm chart with default values fails to install #24218
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@NickLarsenNZ NickLarsenNZ changed the title fix(helm): Use correct default hostname for postgres fix(helm): Use correct default hostnames for postgres and redis May 25, 2023
craig-rueda
craig-rueda reviewed May 26, 2023
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version bump and readme rebuild

@NickLarsenNZ
Copy link
Contributor Author

Missing version bump and readme rebuild

@craig-rueda this has been done now.

@NickLarsenNZ NickLarsenNZ mentioned this pull request May 26, 2023
Merged
9 tasks
@craig-rueda
Copy link
Member

Looks like there's still a linter error

@NickLarsenNZ NickLarsenNZ force-pushed the helm-postgres-hostname branch 2 times, most recently from e32a9d7 to 3e5a9dc Compare May 29, 2023 09:54
@NickLarsenNZ
Copy link
Contributor Author

Good to go now @craig-rueda

@craig-rueda craig-rueda merged commit 9e3875c into apache:master May 30, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart with default values fails to install
3 participants
@NickLarsenNZ @craig-rueda @mistercrunch