Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Currency formatting in Table raw mode #25248

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix: Currency formatting in Table raw mode #25248

merged 2 commits into from
Sep 11, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Sep 10, 2023 •
edited
Loading

SUMMARY

In Table chart's raw mode, the currency formats would not be applied until user also selected a number formatter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

266649024-7e9609f6-bf71-4103-9bb0-f954fdb2e4db.mov

After:

Screen.Recording.2023-09-10.at.15.53.42.mov

TESTING INSTRUCTIONS

  1. Create a table chart and select raw mode
  2. Add some numeric columns
  3. Open "customize columns" popover
  4. Select a currency without changing a number formatter first
  5. Verify that currency is applied

ADDITIONAL INFORMATION

  • Has associated issue: fix: Currency formatting in Table raw mode #25248
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This was referenced Sep 10, 2023
Closed
Merged
michael-s-molina
michael-s-molina approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kgabryje!

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 11, 2023
@kgabryje kgabryje merged commit ea21e80 into apache:master Sep 11, 2023
26 checks passed
michael-s-molina pushed a commit that referenced this pull request Sep 11, 2023
@kgabryje @michael-s-molina
fix: Currency formatting in Table raw mode (#25248)
39dcb29 
(cherry picked from commit ea21e80)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@kgabryje
fix: Currency formatting in Table raw mode (apache#25248)
028d89b
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@kgabryje
fix: Currency formatting in Table raw mode (apache#25248)
b1b6447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgabryje @michael-s-molina @mistercrunch