Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't apply number formatting to the label in Treemap #25249

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: Don't apply number formatting to the label in Treemap #25249

merged 1 commit into from
Sep 11, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Sep 10, 2023 •
edited
Loading

SUMMARY

In Echarts Treemap, the value formatter (number and currency) was unnecessarily applied to labels when labels were numeric. That was both incorrect and inconsistent with other charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Create a Treemap chart
  2. Use a numeric column as a dimension
  3. Verify that only the metric value gets formatter and the label stays unformatted

ADDITIONAL INFORMATION

  • Has associated issue: fix: Currency formatting in Table raw mode #25248
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje mentioned this pull request Sep 10, 2023
Closed
3 tasks
michael-s-molina
michael-s-molina approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kgabryje!

@michael-s-molina michael-s-molina merged commit 894f250 into apache:master Sep 11, 2023
29 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 11, 2023
michael-s-molina pushed a commit that referenced this pull request Sep 11, 2023
@kgabryje @michael-s-molina
fix: Don't apply number formatting to the label in Treemap (#25249)
6d1b969 
(cherry picked from commit 894f250)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@kgabryje
fix: Don't apply number formatting to the label in Treemap (apache#25249
6e04e69 
)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@kgabryje
fix: Don't apply number formatting to the label in Treemap (apache#25249
1e69473 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgabryje @michael-s-molina @mistercrunch