Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update pylint to 2.17.7 #25566

Merged
merged 3 commits into from
Oct 9, 2023
Merged

chore: Update pylint to 2.17.7 #25566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3196dbb
chore: Update pylint to 2.17.7
EugeneTorap Oct 8, 2023
83cc20a
fix pylint errors
EugeneTorap Oct 8, 2023
931fe8d
fix black error
EugeneTorap Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ enable=
# --disable=W"
disable=
cyclic-import, # re-enable once this no longer raises false positives
no-member, # re-enable once this no longer raises false positives. This will become redundant after the min required version is 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EugeneTorap personally I think it is preferable to keep this disables inline. We use the useless-suppression check so when we upgrade to Python 3.11 as a minimum the check will fire. It seems like an cleaner/safer cleanup mechanism that leaving notes in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-bodley Please, check this #24803 PR. We added this line there.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @EugeneTorap. I misread this as an addition as opposed to a removal.

missing-docstring,
duplicate-code,
unspecified-encoding,
Expand Down
4 changes: 2 additions & 2 deletions requirements/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# -r requirements/development.in
appnope==0.1.3
# via ipython
astroid==2.15.6
astroid==2.15.8
# via pylint
asttokens==2.2.1
# via stack-data
Expand Down Expand Up @@ -100,7 +100,7 @@ pyhive[hive_pure_sasl]==0.7.0
# via apache-superset
pyinstrument==4.4.0
# via -r requirements/development.in
pylint==2.17.4
pylint==2.17.7
# via -r requirements/development.in
python-ldap==3.4.3
# via -r requirements/development.in
Expand Down
1 change: 0 additions & 1 deletion superset/cli/test_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ def test_sqlalchemy_dialect(
return engine


# pylint: disable=too-many-statements
def test_database_connectivity(console: Console, engine: Engine) -> None:
"""
Tests the DB API 2.0 driver.
Expand Down
2 changes: 1 addition & 1 deletion superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,7 @@ def dataset_before_update(
from superset.connectors.sqla.models import SqlaTable

# Check if watched fields have changed
table = SqlaTable.__table__
table = SqlaTable.__table__ # pylint: disable=no-member
current_dataset = connection.execute(
table.select().where(table.c.id == target.id)
).one()
Expand Down
2 changes: 1 addition & 1 deletion superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# pylint: disable=too-many-lines, invalid-name
# pylint: disable=invalid-name
from __future__ import annotations

import contextlib
Expand Down
Loading