chore: Simplify views/base #25948
chore: Simplify views/base #25948
Conversation
| payload: Optional[dict[str, Any]] = None, | ||
| link: Optional[str] = None, |
There was a problem hiding this comment.
link parameter is not used in the codebase at all
There was a problem hiding this comment.
@sebastianliebscher it seems like the payload argument isn't use in the codebase either.
There was a problem hiding this comment.
there is a single usage here
superset/superset/views/core.py
Line 166 in d95c200
| ) -> Callable[[Callable[..., FlaskResponse]], Callable[..., FlaskResponse]]: | ||
| """ | ||
| A decorator to set an API endpoint from SupersetView has deprecated. | ||
| Issues a log warning | ||
| """ | ||
|
|
||
| def _deprecated(f: Callable[..., FlaskResponse]) -> Callable[..., FlaskResponse]: | ||
| def wraps(self: "BaseSupersetView", *args: Any, **kwargs: Any) -> FlaskResponse: |
There was a problem hiding this comment.
this was auto-changed by pre-commit pyupgrade
There was a problem hiding this comment.
Thanks @sebastianliebscher for the cleanup. I left a few minor comments, but overall this LGTM.
| payload: Optional[dict[str, Any]] = None, | ||
| link: Optional[str] = None, |
There was a problem hiding this comment.
@sebastianliebscher it seems like the payload argument isn't use in the codebase either.
superset/views/base.py
Outdated
| """ | ||
| Override Response to take into account csv encoding from config.py | ||
| """ | ||
| """Override Response to take into account csv encoding from config.py""" |
There was a problem hiding this comment.
Were these comments manually or automatically changed?
There was a problem hiding this comment.
Manually. If that change is not desired, I'll revert it
There was a problem hiding this comment.
@sebastianliebscher could you please revert these docstring changes.
There was a problem hiding this comment.
@john-bodley Done.
|
The test that is failing is unrelated. There is another PR to address this #25958 |
mistercrunch
added
🏷️ bot
SUMMARY
Simplifies views/base.py to make code more readable / maintainable by using
pyupgrade)TESTING INSTRUCTIONS
ADDITIONAL INFORMATION