test: Reduce flaky integration tests triggered by test_get_tag

[sebastianliebscher]

SUMMARY

Local tests and GitHub CI runs sometimes fail because of

FAILED tests/integration_tests/tags/api_tests.py::TestTagApi::test_get_tag - AssertionError: 'now' != 'a second ago'

Examples from the last two weeks (note: the links will expire)

• https://github.com/apache/superset/actions/runs/6833128031/job/18584558641?pr=25948
• https://github.com/apache/superset/actions/runs/6818394597/job/18543861285
• https://github.com/apache/superset/actions/runs/6732039103/job/18297933474
• https://github.com/apache/superset/actions/runs/6722305797/job/18269963837
• https://github.com/apache/superset/actions/runs/6700573803/job/18206724898

The test now additionally checks for a second ago and two seconds ago as seen in the CI examples above.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

• scripts/tests/run.sh --module tests/integration_tests/tags/api_tests.py::TestTagApi::test_get_tag

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

@cccs-RyanK it seems like you might have authored the original test. Do you have any insights into why said test may be somewhat flakey?

[villebro]

I believe the flakiness is caused by test execution times being variable, causing it to sometimes take longer than usual, which in turn causes the gap between the operations to extend beyond 1 second. I think freezegun could be a good tool here to ensure the test execution time doesn't affect the test result.

[sebastianliebscher]

@villebro thanks for the hint to use freezegun. That is a much cleaner approach now.

[villebro]

LGTM