Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor the github actions has-secrets logic (SIBLING DRAFT PR FOR TESTS) #26806

Closed
wants to merge 5 commits into from
Closed

chore: refactor the github actions has-secrets logic (SIBLING DRAFT PR FOR TESTS) #26806

wants to merge 5 commits into from

Conversation

mistercrunch
Copy link
Member

sibling DRAFT PR to #26795

@mistercrunch
chore: refactor the github actions has-secrets logic
a96ba72 
While working on apache#26772, I
realized that the has-secret logic was broken for unclear reasons. Now
after doing this fix, I looked and realized that there's similar logic
across about a dozen other gh actions, and thought it'd be a good thing
to refactor/fix this with a reusable action.

Now many of these workflows are set to trigger on push-on-master only
meaning it's less of an issue since a false positive on has-secret
dpesn't matter in that context since there's always a secret.

I still thought I should refactor this to something we can trust and
build upon.

The solution introduces this new simple reusable action.

One minor note is in cases where we need multiple secrets, as in say
DOCKERHUB_TOKEN and DOCKERHUB_USER, we simply look at one and assume
that's clear-enough of an indicator.
@mistercrunch
pre-rebase sqash
1221b91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro Awaiting requested review from villebro villebro will be requested when the pull request is marked ready for review villebro is a code owner

@geido geido Awaiting requested review from geido geido will be requested when the pull request is marked ready for review geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho will be requested when the pull request is marked ready for review eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas will be requested when the pull request is marked ready for review rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida will be requested when the pull request is marked ready for review betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai will be requested when the pull request is marked ready for review nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda will be requested when the pull request is marked ready for review craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley will be requested when the pull request is marked ready for review john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje will be requested when the pull request is marked ready for review kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar will be requested when the pull request is marked ready for review dpgaspar is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mistercrunch