Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor the github actions has-secrets logic (SIBLING DRAFT PR FOR TESTS) #26806

Closed
wants to merge 5 commits into from
Closed

chore: refactor the github actions has-secrets logic (SIBLING DRAFT PR FOR TESTS) #26806

wants to merge 5 commits into from

Commits on Jan 25, 2024

  1. chore: refactor the github actions has-secrets logic 

    While working on apache#26772, I
realized that the has-secret logic was broken for unclear reasons. Now
after doing this fix, I looked and realized that there's similar logic
across about a dozen other gh actions, and thought it'd be a good thing
to refactor/fix this with a reusable action.

Now many of these workflows are set to trigger on push-on-master only
meaning it's less of an issue since a false positive on has-secret
dpesn't matter in that context since there's always a secret.

I still thought I should refactor this to something we can trust and
build upon.

The solution introduces this new simple reusable action.

One minor note is in cases where we need multiple secrets, as in say
DOCKERHUB_TOKEN and DOCKERHUB_USER, we simply look at one and assume
that's clear-enough of an indicator.
    @mistercrunch
    mistercrunch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a96ba72 View commit details
    Browse the repository at this point in the history

  2. pre-rebase sqash

    @mistercrunch
    mistercrunch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1221b91 View commit details
    Browse the repository at this point in the history

  3. dummy docs build

    @mistercrunch
    mistercrunch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0f34934 View commit details
    Browse the repository at this point in the history

  4. minor name change

    @mistercrunch
    mistercrunch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    be72795 View commit details
    Browse the repository at this point in the history

  5. dummy commit

    @mistercrunch
    mistercrunch committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    16a80db View commit details
    Browse the repository at this point in the history