Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "chore(build): uplift webpack-related packages to v5 (#28342)" #28384

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: Revert "chore(build): uplift webpack-related packages to v5 (#28342)" #28384

merged 1 commit into from
May 8, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented May 8, 2024 •
edited
Loading

This reverts commit 8c27d4d (PR #28342).

The reason for revert is that after installing the new dependencies and running npm run dev-server, the localhost would not load. Confirmed by @michael-s-molina

CC @hainenber

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje closed this May 8, 2024
@kgabryje kgabryje reopened this May 8, 2024
@michael-s-molina
Copy link
Member

Approving to unblock master. I left a comment here with a possible solution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2024
@kgabryje kgabryje merged commit 5a13e64 into apache:master May 8, 2024
61 of 64 checks passed
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@kgabryje
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
b6ca40a 
…pache#28342)" (apache#28384)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@kgabryje @jzhao62
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
f94ff27 
…pache#28342)" (apache#28384)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@kgabryje @EnxDev
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
f47ed84 
…pache#28342)" (apache#28384)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@kgabryje
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
c7348e2 
…pache#28342)" (apache#28384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
dependencies:npm embedded lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgabryje @michael-s-molina