-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): uplift webpack
-related packages to v5, 2nd attempt
#28440
base: master
Are you sure you want to change the base?
chore(build): uplift webpack
-related packages to v5, 2nd attempt
#28440
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
webpack
-related packages to v5webpack
-related packages to v5, 2nd attempt
Hi @hainenber. It's not working for me. Did you run Screen.Recording.2024-05-13.at.08.32.55.mov |
Signed-off-by: hainenber <dotronghai96@gmail.com>
@michael-s-molina Yes I can confirm the issue not yet resolved. Since IPv4 is still supported for probably eternity in Can you take another look? Thanks! |
@@ -30,7 +30,7 @@ const parsedEnvArg = () => { | |||
}; | |||
|
|||
const { supersetPort = 8088, superset: supersetUrl = null } = parsedEnvArg(); | |||
const backend = (supersetUrl || `http://localhost:${supersetPort}`).replace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fixing anything? Someone might configure localhost to be at another IP, so localhost might be (marginally) safer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah! The answer was right there! 🤦 What a goofy change for them to make.
I wonder if forcing IPV4 like this is risky. Some might change that IP, or some might want IPV6 support.
Maybe it's worth a big find/replace to use "::" rather than "0.0.0.0" everywhere, and "127.0.0.1" to "::1", so that it'll (supposedly) support both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug deeper into the rabbit hole and Node 20 should be able to fix the IPv6-over-IPv4 issues automatically, thanks to this PR.
I tried reverting the localhost
-> 127.0.0.1
change, nvm use 20
, run npm ci && npm run dev-server
and voila, localhost:9000
is proxied properly!
So yeah, this change can wait until Node20 is chosen for superset-frontend
's .nvmrc :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know! @michael-s-molina and I were talking about making this bump as part of the 5.0 release rather than rocking the boat beforehand. I'll try to open a PR with Node 20 sooner rather than later, and just make sure we don't merge it too soon :)
…time Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
chore(build): uplift
webpack
-related packages to v5SUMMARY
2nd attempt of #28342 with implemented solution from @michael-s-molina (thank you very much!)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
npm run dev-server
resultsnpm run build
andnpm run dev
results are OK without issuesTESTING INSTRUCTIONS
ADDITIONAL INFORMATION