Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change fabmanager babel tools to pybabel #2989

Closed
wants to merge 3 commits into from

Conversation

roganw
Copy link
Contributor

@roganw roganw commented Jun 19, 2017

@mistercrunch
Copy link
Member

I almost feel like waiting for the next FAB release on this one.

@xrmx
Copy link
Contributor

xrmx commented Jun 20, 2017

@mistercrunch since it's just documentation this looks like an easy workaround until it's fixed and released in fab though.

@roganw
Copy link
Contributor Author

roganw commented Jun 20, 2017

@mistercrunch It's worthwhile to keep consistent with using FAB commands .

But it has happened that translations extract from __ were overwritten(revert): rebuild translation files

@roganw
Copy link
Contributor Author

roganw commented Jun 21, 2017

@mistercrunch The fix was merged into FAB, which will release 1.9.1 today.
_ and __ are added to the default keywords of fabmanager babel-extract fix babel-extract command
Thank you!

@roganw roganw closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants