Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix babel-extract command #511

Merged
merged 4 commits into from
Jun 20, 2017
Merged

fix babel-extract command #511

merged 4 commits into from
Jun 20, 2017

Conversation

roganw
Copy link
Contributor

@roganw roganw commented Jun 19, 2017

support -k gettext parameter when extract translatable strings using fabmanager babel-extract.

@coveralls
Copy link

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 70.021% when pulling 5c76131 on RoganW:babel-extract into 70193ba on dpgaspar:master.

@dpgaspar
Copy link
Owner

Sorry @roganw,

I made a simple test and babel-extract included my test text in translations file (messages.po).

I added a simple gettext to the views.py

Could you clarify?

@roganw
Copy link
Contributor Author

roganw commented Jun 20, 2017

@dpgaspar There was a problem when use import gettext as __
The test steps:

  • add test code

2017-06-20 12 15 53

  • extract translatable strings by fabmanager babel-extract
    fabmanager babel-extract --target flask_appbuilder/translations/

  • open babel/messages.pot
    There added 3 new translation records:

2017-06-20 12 16 26

But there are no translation record for "Test gettext()"

@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.07%) to 69.956% when pulling c8a05c5 on RoganW:babel-extract into 70193ba on dpgaspar:master.

@dpgaspar
Copy link
Owner

Ok, thanks for the reply. I think that the best would be to add a new optional parameter that accepts multiple values, take a look at: http://click.pocoo.org/5/options/#tuples-as-multi-value-options

This way we could add whatever exception(s) one would like.

And then please add some docs to support it: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/docs/fabmanager.rst

Thank you!

@dpgaspar
Copy link
Owner

I would like to release new 1.9.1 tomorrow, will you be able to it until then?

@roganw
Copy link
Contributor Author

roganw commented Jun 20, 2017

@dpgaspar Done.

@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.07%) to 69.95% when pulling ec49fd6 on RoganW:babel-extract into 70193ba on dpgaspar:master.

@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.07%) to 69.95% when pulling ec49fd6 on RoganW:babel-extract into 70193ba on dpgaspar:master.

@dpgaspar
Copy link
Owner

Great! thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants