-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump cypress to v 11 #30262
chore: bump cypress to v 11 #30262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's hope this fixes that flaky test! One comment on the removed config.
requestTimeout: 10000, | ||
video: false, | ||
videoUploadOnPasses: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this removal intentional? I don't see it mentioned in the docs or the description..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it was flagged by typescript that it no longer exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, that explains why it wasn't mentioned in the docs 😄
e0d57c7
to
a959afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a way to upgrade with a GUI using npx
if you're not already aware. I've been curious how well that works, maybe it'll be helpful for the next bumps.
Oh nice. I'll try that. There's also a PR already where someone did the difficult work of bumping to v13. I was thinking of reviving that PR. |
SUMMARY
Per the cypress docs, this experimental flag should help with some of the chromium memory problems we've been seeing, but it needs at least v12 in order to do anything:
https://docs.cypress.io/guides/references/error-messages#The-Chromium-Renderer-process-just-crashed
Bumping this version to 11. We'll do 12 in a separate PR
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION