Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cypress to v 11 #30262

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: bump cypress to v 11 #30262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5888913
add memory management to cypress config
eschutho Sep 12, 2024
a959afe
bump cypress
eschutho Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions superset-frontend/cypress-base/cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,17 @@
import { defineConfig } from 'cypress';
import eyesPlugin from '@applitools/eyes-cypress';

const { verifyDownloadTasks } = require('cy-verify-downloads');

export default eyesPlugin(
defineConfig({
chromeWebSecurity: false,
defaultCommandTimeout: 8000,
numTestsKeptInMemory: 0,
experimentalFetchPolyfill: true,
experimentalMemoryManagement: true,
requestTimeout: 10000,
video: false,
videoUploadOnPasses: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removal intentional? I don't see it mentioned in the docs or the description..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was flagged by typescript that it no longer exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, that explains why it wasn't mentioned in the docs 😄

viewportWidth: 1280,
viewportHeight: 1024,
projectId: 'ud5x2f',
Expand Down Expand Up @@ -60,9 +62,11 @@ export default eyesPlugin(
}
return launchOptions;
});

// eslint-disable-next-line global-require
require('@cypress/code-coverage/task')(on, config);
on('task', verifyDownloadTasks);
// eslint-disable-next-line global-require,import/extensions
return require('./cypress/plugins/index.js')(on, config);
return config;
},
baseUrl: 'http://localhost:8088',
excludeSpecPattern: [],
Expand Down
31 changes: 0 additions & 31 deletions superset-frontend/cypress-base/cypress/plugins/index.js
View file
Open in desktop

This file was deleted.

28 changes: 14 additions & 14 deletions superset-frontend/cypress-base/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions superset-frontend/cypress-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@cypress/code-coverage": "^3.10.4",
"@superset-ui/core": "^2.1.0",
"brace": "^0.11.1",
"cy-verify-downloads": "^0.1.6",
"cy-verify-downloads": "^0.2.5",
"cypress-fail-on-console-error": "^4.0.3",
"querystringify": "^2.2.0",
"react-dom": "^16.13.0",
Expand All @@ -29,7 +29,7 @@
},
"devDependencies": {
"@types/querystringify": "^2.0.0",
"cypress": "^10.11.0",
"cypress": "^11.2.0",
sadpandajoe marked this conversation as resolved.
Show resolved Hide resolved
"eslint-plugin-cypress": "^3.5.0"
}
}
Loading