[pie] improvements to pie charts #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
Codecov Report
@@ Coverage Diff @@
## master #5236 +/- ##
==========================================
- Coverage 63.46% 63.45% -0.01%
==========================================
Files 261 261
Lines 19845 19846 +1
Branches 1998 1998
==========================================
Hits 12594 12594
- Misses 7242 7243 +1
Partials 9 9
Continue to review full report at Codecov.
|
|
@hughhhh 👀 |
|
🏓 |
|
🐑 |
hughhhh
approved these changes
Jul 10, 2018
xumiao
pushed a commit
to xumiao/supernorm
that referenced
this pull request
Jul 16, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
mistercrunch
added a commit
that referenced
this pull request
Aug 12, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Aug 20, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]` (cherry picked from commit f9352af)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 20, 2018
[pie] improvements to pie charts (apache#5236)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Pie chart was using `limit` instead of `row_limit` which didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded. Unrelated drive-by fix of setting "percentage metric" to default to `[]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pie chart was using
limitinstead ofrow_limitwhich didn't work. Also set a lower default limit to 25 to prevent the chart from getting super crowded.Added
show_labelsto formatting options and a tooltip message making it clear that <5% won't show labels.Unrelated drive-by fix of setting "percentage metric" to default to
[]closes #5210
@betodealmeida 👀