-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization Unicode bug fix #5387
Conversation
LGTM, can you rebase please. I think |
The travis build has been failing for 2 reasons recently * pylint takes > 10 minutes without outputing * bad merge confict auto resolve in controls.jsx
…rset into jrahman/VizUnicodeFix
Codecov Report
@@ Coverage Diff @@
## master #5387 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 23747 23747
Branches 2758 2758
======================================
Hits 14036 14036
Misses 9696 9696
Partials 15 15
Continue to review full report at Codecov.
|
Updated and resubmitted. @mistercrunch please merge to master when you get chance :-) |
@JamshedRahman: Please, can you add the following change into your PR. The issue #5479 has more details |
Ooops, noticed the new comment after merging. It should be able to create a new PR with that change. |
* Visualization Unicode bug fix * Fix the build (apache#5403) The travis build has been failing for 2 reasons recently * pylint takes > 10 minutes without outputing * bad merge confict auto resolve in controls.jsx * Visualization Unicode bug fix
This change fixes unicode data errors in Python 2. Replacing str() with six.text_type(), which is unicode() in Python 2 and str() in Python 3.
This change is an extension of #5093 for all viz types.
Also includes an unit test for time series viz types.