Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization Unicode bug fix #5387

Merged
merged 5 commits into from
Jul 26, 2018
Merged

Conversation

JamshedRahman
Copy link
Contributor

This change fixes unicode data errors in Python 2. Replacing str() with six.text_type(), which is unicode() in Python 2 and str() in Python 3.
This change is an extension of #5093 for all viz types.
Also includes an unit test for time series viz types.

@JamshedRahman
Copy link
Contributor Author

This build is failing due to an unrelated issue. Looks like #5236 and #5357 are creating a conflict due to duplicate keys in controls.jsx line 211. Please fix controls.jsx...

@mistercrunch
Copy link
Member

LGTM, can you rebase please. I think master may have been broken at the time you created your branch.

mistercrunch and others added 4 commits July 17, 2018 15:53
The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
@codecov-io
Copy link

Codecov Report

Merging #5387 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5387   +/-   ##
======================================
  Coverage    59.1%   59.1%           
======================================
  Files         372     372           
  Lines       23747   23747           
  Branches     2758    2758           
======================================
  Hits        14036   14036           
  Misses       9696    9696           
  Partials       15      15
Impacted Files Coverage Δ
superset/viz.py 77.34% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8eaee...6de97eb. Read the comment docs.

@JamshedRahman
Copy link
Contributor Author

Updated and resubmitted. @mistercrunch please merge to master when you get chance :-)

@mmuru
Copy link

mmuru commented Jul 26, 2018

@JamshedRahman: Please, can you add the following change into your PR. The issue #5479 has more details
Line 753 in superset/models/core.py sqls = [str(s).strip().strip(';') for s in sqlparse.parse(sql)] should change to sqls = [six.text_type(s).strip().strip(';') for s in sqlparse.parse(sql)]
I tested this change and worked.

@mistercrunch mistercrunch merged commit 54fba0f into apache:master Jul 26, 2018
@mistercrunch
Copy link
Member

Ooops, noticed the new comment after merging. It should be able to create a new PR with that change.

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Visualization Unicode bug fix

* Fix the build (apache#5403)

The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx

* Visualization Unicode bug fix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants