Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5479 - unicode columns issue. #5508

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Fix 5479 - unicode columns issue. #5508

merged 1 commit into from
Jul 27, 2018

Conversation

mmuru
Copy link

@mmuru mmuru commented Jul 27, 2018

This PR fixes the remain unicode regression issue (#5387).

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #5508 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5508   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         349      349           
  Lines       22110    22110           
  Branches     2455     2455           
=======================================
  Hits        14013    14013           
  Misses       8083     8083           
  Partials       14       14
Impacted Files Coverage Δ
superset/models/core.py 86.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd55998...1b325d2. Read the comment docs.

@mistercrunch mistercrunch merged commit 213fb64 into apache:master Jul 27, 2018
@mmuru
Copy link
Author

mmuru commented Jul 27, 2018

@mistercrunch: Please, review and merge it when you get chance.

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants